UrlShortenerBundle icon indicating copy to clipboard operation
UrlShortenerBundle copied to clipboard

Only flush the link entity, fixes #12

Open tacman opened this issue 8 years ago • 4 comments

tacman avatar Nov 02 '17 10:11 tacman

Hi @tacman ,

Can you add some unit tests please and add a CHANGELOG.md at the root of the project:

CHANGELOG
=========

2017-11-02
----------

* Fix #12: only flush the given link

mremi avatar Nov 02 '17 11:11 mremi

@tacman pretty sure you'll be able to write some tests looking at the existing ones in https://github.com/mremi/UrlShortenerBundle/blob/master/Tests/Doctrine/LinkManagerTest.php.

Can you please add the CHANGELOG.md I give you above (and squash your commits to have only one).

mremi avatar Nov 03 '17 14:11 mremi

@tacman hi, any news?

mremi avatar Nov 15 '17 12:11 mremi

Unfortunately (and embarrassingly), I'm lousy at writing tests. I think I can write the test in the class you've recommended, but I'm not sure how to run them.

I keep getting:

PHP Fatal error: Class 'PHPUnit_Framework_TestCase' not found

Can you add to the documentation how to test the Bundle itself, and I'll try to follow along and add it?

Realistically, though, my ability to write these kind of tests is very limited. :-(

Tac

On Wed, Nov 15, 2017 at 7:31 AM, Rémi Marseille [email protected] wrote:

@tacman https://github.com/tacman hi, any news?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mremi/UrlShortenerBundle/pull/13#issuecomment-344578596, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl0QcCAOtGhQGwQbeOlTy8mataMG5zvks5s2tmVgaJpZM4QPduP .

tacman avatar Nov 15 '17 12:11 tacman