Integration of Short.cm provider

Open felixmaier1989 opened this issue 6 years ago • 6 comments

Integration of https://short.cm/api

May 10 '19 06:05 felixmaier1989

Note that Travis is likely to fail as Composer dropped support for HHVM https://github.com/composer/composer/issues/8127

May 10 '19 07:05 felixmaier1989

Could you please replace hhvm by 7.2 and add 7.3 as well in .travis.yml?

May 22 '19 07:05 mremi

Could you please update CHANGELOG.md as well? Thanks

May 22 '19 07:05 mremi

Travis fails for PHP 7.2 and 7.3. @mremi As I'm not a Travis expert at all, can I hand fixing it over you?

May 23 '19 03:05 felixmaier1989

Travis is failing because of a deprecation: The each() function is deprecated. You should be able to reproduce it if you have a runtime in PHP 7.2 by running make test

May 23 '19 06:05 mremi

I only have 7.0 and 7.1 available locally. I dont have time setting up a local container for PHP 7.2 or 7.3. My company is running through high season.

May 28 '19 11:05 felixmaier1989