Matthew Reishus

Results 73 comments of Matthew Reishus

If they were combined into a single document, would there be difficulty bringing the user to the variation that matched their search? With different documents, we could set the individual...

Here's a separate approach for putting the SKUs and Description in the main document - 185530-ghe-Automattic/wpcom - please check it out @gibrown

Hello, We did this intentionally in this issue: https://github.com/Automattic/wp-calypso/issues/59991 I believe it's related to the FSE changes. [From this WordPress.org blogpost](https://make.wordpress.org/core/2022/01/07/state-of-the-customizer-with-block-themes-in-wordpress-5-9/) >"WordPress removes the Customizer from the Appearance menu if...

In terms of performance, when a site gets into a state that queues up too many of these actions, it can accumulate over 100 million rows in the action scheduler...

We saw excessive jobs even on a site with the fix in #57588 installed. While that limits each individual job to being queued only once, as soon as that job...

I suppose reverting the queuing would help lower the "contagion" of the misbehaving plugin. When it's scheduling jobs, the large number of action rows, combined with default retention settings, can...

I saw the revert made it in. Do we still want to do this? If so, would splitting out the context detection logic be a good idea in case there...

I believe there's a possible dependency/ordering issue here: https://github.com/mreishus/woocommerce/blob/a3f4439db072dddbc43f88cc7ec99d8c3b40ac24/plugins/woocommerce-blocks/bin/blocks-json-to-php.js#L20 This is where the build step inside `plugins/woocommerce-blocks` is "reaching into" `plugins/woocommerce` to include a few blocks in the built php...

Explaining the problem in more detail: ### Clean build: ``` pnpm run clean pnpm run clean:build pnpm install --frozen-lockfile pnpm run build wc -l plugins/woocommerce-blocks/build/blocks-json.php ## See: 4928 ``` ###...

For problem 3, let's look at one example closer: `product-filter-rating`: * A "built" repository has `./plugins/woocommerce/assets/client/blocks/product-filter-rating/block.json` created by a build process. * A clean repository is missing `./plugins/woocommerce/assets/client/blocks/product-filter-rating/block.json`. * Both...