py-wkhtmltox icon indicating copy to clipboard operation
py-wkhtmltox copied to clipboard

Code added to allow passing HTML via "add_page({"data": "html string"})"

Open fre-sch opened this issue 12 years ago • 5 comments

Reading the documentation (http://www.cs.au.dk/~jakobt/libwkhtmltox_0.10.0_doc/pdf_8h.html#a338e8f880bd3a53ec03be897548a6919) I noticed it's possible to pass HTML directly.

This is my first pull-request, I hope everything is ok ;)

fre-sch avatar Dec 13 '12 11:12 fre-sch

cool, thanks!

mreiferson avatar Dec 13 '12 14:12 mreiferson

can you add the diff to the wkhtmltox.c file so that it isn't necessary to have cython installed to install this module?

mreiferson avatar Dec 13 '12 15:12 mreiferson

Sure will. As soon as I get home :)

fre-sch avatar Dec 13 '12 17:12 fre-sch

Please let me know if there are issues preventing the merge. I'll be happy to fix them :)

fre-sch avatar Feb 01 '13 13:02 fre-sch

@fre-sch didn't realize you pushed that commit up that evening :)

would you mind squashing this down into one commit (note: no need for a new pull request... just push over this branch, please)?

mreiferson avatar Feb 01 '13 14:02 mreiferson