Matthias Endler
Matthias Endler
Maybe I'm a bit biased, but I noticed that there are a lot of duplicate links in internal documentation such as wikis and tool documentation. The reason might be that...
One thing I don't like about the existing file output is that the paths can get really long and start to feel noisy. But you helped me understand that the...
`lychee-cli` seems fine. An alternative name might be `lychee-bin`, which is in alignment with the crate name. It has the added advantage that `lychee-lib` could be used as the canonical...
If a link occurs multiple times within one file, this shouldn't happen. Duplicates can still occur if a link appears on two different pages and the link is not in...
> Make AcceptRange only produce valid HTTP status codes. My vote goes to this. If we make invalid state unrepresentable, we can avoid it propagating across the codebase. We tackle...
Alternatively, errors without a status code should never be cacheable. I don't know if there's any unexpected side effect from that, but the cache entry certainly looks weird.
I would like to hear some more opinions on this first before making any bad decisions. I have a track record for those. 😅
@Thiru, any updates? Let me know in case you need any help. 😃
Thanks, sounds good!
I've added a few more comments. Most of them are minor. I think it should be fairly easy to go through them and accept/reject my suggestions from the GitHub UI....