Matthias Endler

Results 663 comments of Matthias Endler

Perfect. Great work! Perhaps the only thing I'd add is an integration test, similar to this: https://github.com/lycheeverse/lychee/blob/eff77d634283610dbdd481db2d9b1d1162cdea84/lychee-bin/tests/cli.rs#L794-L858 Probably it's just a matter of copy-pasting that block and changing the parameter,...

Just tested the changes locally. When I run lychee like below, the cache is empty: ```sh ❯❯❯ cargo run -- --verbose --cache https://lychee.cli.rs/ Finished dev [unoptimized + debuginfo] target(s) in...

I've added the integration test we discussed, and that one seems to work. Something isn't adding up here. 🤔

Sorry for the late response. The feature doesn't work right now. I tested it by excluding only a single status code, but it excludes everything. > Could that be related...

> The summary (see below) which is printed in the end still shows emojis, is this not part of #546 and this PR? Oh, nice catch. Maybe I should fix...

Maybe I should add some tests before this can be merged.

Finally got around to merging this! Thanks for the review, @thomas-zahner.

The linked PR has a proposed solution now. @jan-ferdinand fyi.

This is now fixed in `master` and will be released with the next version. Thanks @jan-ferdinand for the test and for opening the issue.