three.js icon indicating copy to clipboard operation
three.js copied to clipboard

Examples: Clean up

Open WestLangley opened this issue 1 year ago • 3 comments
trafficstars

The arguments were swapped.

darkness is in [0, 1].

WestLangley avatar Aug 22 '24 15:08 WestLangley

@Mugen87 I am unable to successfully create a screenshot for some reason. Can you please give it a try?

WestLangley avatar Aug 22 '24 15:08 WestLangley

I wasn't able to push to your branch but here is the updated screenshot. I hope GitHub does not further compress the image.

webgl_postprocessing_advanced

Mugen87 avatar Aug 22 '24 18:08 Mugen87

Thanks, @Mugen87, but e2e is failing... Trying to figure out what is going on. :/

WestLangley avatar Aug 22 '24 19:08 WestLangley

@Mugen87 You screenshot may be compressed. It is not passing e2e. And my screenshots are black.

I wasn't able to push to your branch

Not sure why that is, either. It says "Maintainers are allowed to edit this pull request."

WestLangley avatar Sep 17 '24 14:09 WestLangley

Now it works! I guess I was on the wrong branch, not dev-clean_up.

Mugen87 avatar Sep 17 '24 16:09 Mugen87