three.js icon indicating copy to clipboard operation
three.js copied to clipboard
verified publisher icon mrdoob

New WebGLNodeBuilder + Nodes: transmission

Open sunag opened this issue 3 years ago • 4 comments

Related issue: https://github.com/mrdoob/three.js/pull/24385

Description

Part 4 / 4

I rewrote the Slots API and I added transmission*Node and specular*Node, iorNode. Now WebGLNodeBuilder can detect the precedence of the slots and added the code/snippet always in the correct sequence.

This contribution is funded by Google via Igalia

sunag avatar Aug 05 '22 05:08 sunag

Is that output correct?

mrdoob avatar Aug 05 '22 06:08 mrdoob

Is that output correct?

Yees! hehe :grin: I put a normalWorld in colorNode... do you think I should remove it?

https://github.com/mrdoob/three.js/blob/f24997e1830107f8a154683c12be44dc9ec30cef/examples/webgl_nodes_loader_gltf_transmission.html#L87-L89

sunag avatar Aug 05 '22 10:08 sunag

Yees! hehe :grin: I put a normalWorld in colorNode... do you think I should remove it?

Yeah, it looks like it's broken otherwise 😅

mrdoob avatar Aug 09 '22 05:08 mrdoob

Yeah, it looks like it's broken otherwise 😅

Ok, done!!

sunag avatar Aug 09 '22 18:08 sunag

image

Still looks broken, in a different way now 😇

mrdoob avatar Aug 10 '22 12:08 mrdoob

Updated :)

sunag avatar Aug 10 '22 14:08 sunag

Thanks!

mrdoob avatar Aug 12 '22 04:08 mrdoob