three.js icon indicating copy to clipboard operation
three.js copied to clipboard

Change alias 'three-nodes' → 'three/nodes'

Open donmccurdy opened this issue 1 year ago • 2 comments

Related:

  • https://github.com/mrdoob/three.js/issues/24377
  • https://github.com/mrdoob/three.js/pull/23368

In my opinion, any aliases in exported modules should be under the three/* namespace. Otherwise, it looks like an import from an unknown NPM module to tooling. If we'd like to do so, we could add the three/nodes entry in package.json#exports, allowing bundlers and some CDNs to resolve this import automatically, but I haven't taken that extra step here.

/cc @sunag @marcofugaro @robertlong

donmccurdy avatar Aug 01 '22 01:08 donmccurdy

Also related: https://github.com/mrdoob/three.js/pull/23406

LeviPesin avatar Aug 01 '22 08:08 LeviPesin

Makes sense, thanks for the PR! 👍

marcofugaro avatar Aug 01 '22 13:08 marcofugaro

@donmccurdy could you solve the conflicts on this PR?

Also I think this PR should be merged soon to avoid any more confusion for the users.

marcofugaro avatar Aug 24 '22 16:08 marcofugaro

Updated!

sunag avatar Aug 24 '22 17:08 sunag

Thanks!

mrdoob avatar Aug 25 '22 17:08 mrdoob