three.js
three.js copied to clipboard
Change alias 'three-nodes' → 'three/nodes'
Related:
- https://github.com/mrdoob/three.js/issues/24377
- https://github.com/mrdoob/three.js/pull/23368
In my opinion, any aliases in exported modules should be under the three/*
namespace. Otherwise, it looks like an import from an unknown NPM module to tooling. If we'd like to do so, we could add the three/nodes
entry in package.json#exports
, allowing bundlers and some CDNs to resolve this import automatically, but I haven't taken that extra step here.
/cc @sunag @marcofugaro @robertlong
Also related: https://github.com/mrdoob/three.js/pull/23406
Makes sense, thanks for the PR! 👍
@donmccurdy could you solve the conflicts on this PR?
Also I think this PR should be merged soon to avoid any more confusion for the users.
Updated!
Thanks!