three.js
three.js copied to clipboard
Deprecate legacy BufferGeometry nomenclature for built-in geometries
As proposed in https://github.com/mrdoob/three.js/pull/24349#issuecomment-1185312799.
Does this look like the right approach? If so, I'll add the remaining geometries.
I think the right approach would be to do this in BoxGeometry.js instead of Three.Legacy.js.
We only put deprecated methods or properties into non-deprecated classes. Legacy classes should go into Three.Legacy.js.
Does this look like the right approach?
Looking good.
Let's merge before too many conflicts ensue. New build required.
TBH, I want that @mrdoob merges this PR (and #24346). I'm not sure about his preferences regarding the geometry generator aliases.
TBH, I want that @mrdoob merges this PR...
@mrdoob What do you think? 😇
What if we just removed these aliases? 🤔
What if we just removed these aliases?
@Mugen87 What do you prefer?
I've thought the policy was to first deprecated things and then make the removal after 10 releases. I personally would prefer to keep doing this especially in this case since I frequently see the usage of BoxBufferGeometry or PlaneBufferGeometry in user code.
@Mugen87 Sounds good!
Thanks!