three.js icon indicating copy to clipboard operation
three.js copied to clipboard

Deprecate legacy BufferGeometry nomenclature for built-in geometries

Open WestLangley opened this issue 3 years ago • 5 comments

As proposed in https://github.com/mrdoob/three.js/pull/24349#issuecomment-1185312799.

Does this look like the right approach? If so, I'll add the remaining geometries.

WestLangley avatar Jul 15 '22 23:07 WestLangley

I think the right approach would be to do this in BoxGeometry.js instead of Three.Legacy.js.

LeviPesin avatar Jul 16 '22 08:07 LeviPesin

We only put deprecated methods or properties into non-deprecated classes. Legacy classes should go into Three.Legacy.js.

Does this look like the right approach?

Looking good.

Mugen87 avatar Jul 16 '22 08:07 Mugen87

Let's merge before too many conflicts ensue. New build required.

WestLangley avatar Jul 18 '22 13:07 WestLangley

TBH, I want that @mrdoob merges this PR (and #24346). I'm not sure about his preferences regarding the geometry generator aliases.

Mugen87 avatar Jul 18 '22 15:07 Mugen87

TBH, I want that @mrdoob merges this PR...

@mrdoob What do you think? 😇

WestLangley avatar Jul 22 '22 04:07 WestLangley

What if we just removed these aliases? 🤔

mrdoob avatar Aug 11 '22 00:08 mrdoob

What if we just removed these aliases?

@Mugen87 What do you prefer?

WestLangley avatar Aug 11 '22 12:08 WestLangley

I've thought the policy was to first deprecated things and then make the removal after 10 releases. I personally would prefer to keep doing this especially in this case since I frequently see the usage of BoxBufferGeometry or PlaneBufferGeometry in user code.

Mugen87 avatar Aug 11 '22 14:08 Mugen87

@Mugen87 Sounds good!

mrdoob avatar Aug 12 '22 04:08 mrdoob

Thanks!

mrdoob avatar Aug 12 '22 04:08 mrdoob