three.js icon indicating copy to clipboard operation
three.js copied to clipboard

Make icon repsonsive to color scheme preference

Open greggman opened this issue 2 years ago • 7 comments

I'm not sure if you want this or not but it will make the icon responsive to the user's color preference.

I chose #DDD instead of #FFF because if the page didn't set a body/html background color the page will be white and the icon will then be white on white.

greggman avatar Oct 11 '21 17:10 greggman

Just for my understanding: Where is icon.svg currently used? It seems this file is not referenced once in the entire repo 🤔 .

Mugen87 avatar Oct 13 '21 15:10 Mugen87

yea, it's not. I feel like I saw the logo used somewhere at some point, maybe the docs? Though it's not there now so maybe I have a bad memory. In any case, this is one way to make a responsive diagram/icon

greggman avatar Oct 13 '21 19:10 greggman

Oh! Can we use svg as favicons now?

I recently implemented favicon color scheme support like this: https://github.com/mrdoob/three.js/commit/c46c105639dbd8981f306afc11412fccac29890d

mrdoob avatar Oct 14 '21 19:10 mrdoob

Seems the browser support is not good enough yet: https://caniuse.com/link-icon-svg

Mugen87 avatar Oct 19 '21 13:10 Mugen87

Still, you can use it if you decided to put an image in any docs or the editor or the home page etc....

greggman avatar Oct 21 '21 07:10 greggman

I'm hesitant about this one...

It'd be like having a gltf that uses different materials depending on prefers-color-scheme. What happens if the developer, for whatever reason, doesn't want to add support to prefers-color-scheme?

mrdoob avatar Oct 28 '21 12:10 mrdoob

I assumed this icon was for the site, not for other developers. So that maybe in the docs or the home page you wanted a logo and you'd like that logo to be responsive to the color scheme just like the page itself is Screen Shot 2021-10-28 at 9 28 36 Screen Shot 2021-10-28 at 9 28 24

I know you're not using it for that now.

You could rename it icon-color-scheme-responsive.svg

greggman avatar Oct 28 '21 16:10 greggman

Closing. Let's change the icon when there is a concrete use case.

Mugen87 avatar Feb 27 '24 12:02 Mugen87