Fixed some console warnings and touch positions on mobile

Open mikebourbeauart opened this issue 2 years ago • 3 comments

Set all addEventListener calls from false to {pass: false} which seems to fix the console warnings related to preventDefault
My art director loves this app and he said it broke for him a few weeks ago on mobile. Maybe something changed in JS with how touch location works in the events? Any who, I multiplied the touch x and y positions by the PIXEl_RATIO and things seem to be working again on my end

Oct 26 '23 22:10 mikebourbeauart

Hmm, could you revert the linting changes?

Nov 06 '23 01:11 mrdoob

Damn... There are so many things to fix in my current code.

I think I'm going to have to refactor the whole thing...

Nov 06 '23 01:11 mrdoob

Ya I can revert those, sorry about that!

In my fork I was able to get it all built and working using webpack.

I'm also doing a migration to React as a way to learn, so maybe I can PR that if you don't get around to updating this on your own!

Nov 06 '23 02:11 mikebourbeauart