minify icon indicating copy to clipboard operation
minify copied to clipboard
verified publisher icon mrclay

Minify::_combineMinify should combine before minifying

Open mrclay opened this issue 14 years ago • 5 comments

For sake of remote ClosureCompiler API use, we should bring back behavior of combining before minifying, maybe except for CSS.

See https://github.com/mrclay/minify/blob/master/min/lib/Minify.php#L490

mrclay avatar Oct 07 '11 19:10 mrclay

Fixed in f67da8e359059ca877063411f6efd15cc5f9746a

mrclay avatar Oct 14 '11 03:10 mrclay

Joe said: "I assume there are fewer API calls because now I just get the following error: "Minify: Exception in minifier: POST content larger than 200000 bytes""

mrclay avatar Oct 14 '11 17:10 mrclay

The branch "issue6" moves Minify::_combineMinify to Minify_Process::process and adds support for minifier classes exposing the maximum bytes they can handle. d87780ecb8872a33bd93ed069431f4aff7d38e01

mrclay avatar Oct 14 '11 21:10 mrclay

Let me know if there is anything I can do to help resolve this issue.

lencioni avatar Mar 29 '12 20:03 lencioni

I'd forgot about this branch. I think this needs to go in the (eventual) refactoring. It seems just to add to the current mess.

mrclay avatar Mar 29 '12 20:03 mrclay