rustaceanvim icon indicating copy to clipboard operation
rustaceanvim copied to clipboard
verified publisher icon mrcjkb

feat: use luasnip snippet text edit handler if available

Open mrcjkb opened this issue 1 year ago • 6 comments

Closes #412

mrcjkb avatar Jun 07 '24 09:06 mrcjkb

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • [ ] Pull request title has the appropriate conventional commit prefix.

If applicable:

  • [ ] Tested
    • [ ] Tests have been added.
    • [x] Tested manually (Steps to reproduce in PR description).
  • [ ] Updated documentation.
  • [ ] Updated CHANGELOG.md

github-actions[bot] avatar Jun 07 '24 09:06 github-actions[bot]

Hey, when will this be merged :)

xzbdmw avatar Oct 29 '24 22:10 xzbdmw

@xzbdmw it's blocked by https://github.com/L3MON4D3/LuaSnip/issues/235

mrcjkb avatar Oct 29 '24 23:10 mrcjkb

For what I understand, Is it expected to wait until https://github.com/rust-lang/rust-analyzer/issues/16604?

xzbdmw avatar Oct 29 '24 23:10 xzbdmw

For what I understand, Is it expected to wait until rust-lang/rust-analyzer#16604?

Yes.

mrcjkb avatar Oct 29 '24 23:10 mrcjkb

Oh there will be a builtin one https://github.com/neovim/neovim/pull/30287

xzbdmw avatar Nov 02 '24 06:11 xzbdmw