Arraymancer icon indicating copy to clipboard operation
Arraymancer copied to clipboard
verified publisher icon mratsim

Add division gate

Open jegork opened this issue 2 years ago • 1 comments

Hello!

This PR adds broadcasted division operation (/.) for the Variable type. I am quite new to the codebase so any suggestions are welcome.

Thanks!

jegork avatar Jan 08 '23 10:01 jegork

Sorry this didn't receive any attention since January! I've unfortunately also been too busy and kept away from Github.

Thanks for the contribution! It generally looks good to me, aside from that minor comment.

Vindaar avatar Apr 03 '23 13:04 Vindaar

Since it's approved should this be merged ?

Clonkk avatar Jun 07 '24 14:06 Clonkk

@Clonkk sorry, completely forgot about this PR, I can take a look at the suggestions of @Vindaar or we can have it merged, what's your suggestion?

jegork avatar Jun 07 '24 14:06 jegork

I leave it up to @Vindaar since he reviewed it. But if both of you are satisfied then it should be merged

Clonkk avatar Jun 07 '24 14:06 Clonkk

Thanks and sorry again for ignoring it for such a long time :)

Vindaar avatar Jun 10 '24 16:06 Vindaar