mransan
mransan
#28 is fixing the default value for `optional` fields.
@tiziano88 this is definitely needed and I agree with you it should be supported. I'll work on a possible solution.
I like the first one for sure. Since the size estimation would be recursive, your technique should also make what @c-cube proposed in #157 redundant. (just to confirm I got...
when you say `cannot create a batch message where the sequence field is absent` you mean at the binary level? In other word the empty list does make it to...
ok so looking at this again On the ocaml-protoc generated, If the list is empty then it could eithe be ommited in the binary or encoded as empty list. Both...
So what you mean is that Pbrt should be its own opam package so that we can limit the dependency of the generated code on that. I agree that it...
A couple of general comment (around the same theme) * "fromList is inefficient": this is all relative and really up to the user to decide whether it meets its performance...
@glennsl "fromList" is not inefficient, it's just a convertor between 2 containers. If we're discussing 2 implementations differences of that function and one is more performant than another I would...
@glennsl @dorafmon, so fromSequence is: ``` let fromSequence i = of_list @@ Sequence.foldLeft (fun acc item -> acc @ [item]) [] i ``` So now I need to convert my...
@bordoley efficiency is relative and depends on the context. Take this example: you call a third party API (no control over it) which returns a list, you then want to...