Slava Egorov comments

Results 443 comments of


                                            Slava Egorov

Better subclass handling for `argument_type_not_assignable`

Note that `invalid_assignment` probably has the same issue. We should probably check all error messages which include multiple types because the problem can arise in any of them.

JsonCodable macro field names

> any updates about this feature ? Dart 3.5.1 is live and i want to use `macros` intead of any `build_runner` libraries. Macros is an experimental unreleased feature provided as...

`PropertyAccessorElementImpl`: optimize `name` getter to avoid calls to `considerCanonicalizeString`

@gmpassos what is the status of this change?

`PropertyAccessorElementImpl`: optimize `name` getter to avoid calls to `considerCanonicalizeString`

@bwilkerson @scheglov please make a call if you want to accept or reject this PR and if you would like to accept submit corresponding CL to CQ (FWIW @bwilkerson has...

`_IndexAssembler.assemble`: optimize using `toList(growable: false)`

@gmpassos @bwilkerson what is the status of this change?

`_IndexAssembler.assemble`: optimize using `toList(growable: false)`

@bwilkerson @scheglov same here, please make a call and either accept (+1 & +2 the CL) or reject the PR. Thanks!

Not able to close/release RawDatagramSocket after receiving a SocketException in Windows Desktop

cc @brianquinlan

Converting object to an encodable object failed: Instance of 'MultipartRequest'

Closing as stale. I think it was this line: `json.encode(request)` that was throwing because `MultipartRequest` does not define `toJson` method - but why would it?

Unnecessary thread and pipe overhead waiting for child processes to exit on Linux and Mac

This requires 5.3+ kernel version and I think our supported targets cover some OSes with 4.x kernels e.g. Flutter claims support for Debian 10 which I think comes with 4.19...

gen_snapshot: Direct generation of PE / DLL when AOT compiling for Windows

We should consider to generating COFF so that we could statically link snapshot and runtime as well. (The same for ELF and Mach-O - we should generate appropriate object file...