Slava Egorov comments

Results 443 comments of


                                            Slava Egorov

service_2/evaluate_activation_test/* tests went from flaky to RuntimeError on dartk-mac-debug-x64

The test should probably be adjusted to reflect the current implementation, however there is a deeper question of _developer experience_ here and how to balance it with our desire for...

Support symbolication for pure Dart apps

regarding `dart:mirrors` and `libraries`. You should not confuse _dynamic libraries_ (as in: object files loaded by runtime linker like `ld` or `dyld`) and _Dart libraries_ (which is just a unit...

Regarding "removing the Dart SDK constraints, from pubspec".

Dart SDK constraints are mandatory in pubspec.yaml since Dart 2.12. See https://github.com/dart-lang/sdk/issues/44072

[webview_flutter] iOS Flutter got crash because of [FLTWKNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:] was not called

@flutter-symbolizer-bot this force flutter#v2.10.4 ios release arm64 ``` Fatal Exception: NSInternalInconsistencyException 0 CoreFoundation 0x99d78 __exceptionPreprocess 1 libobjc.A.dylib 0x16734 objc_exception_throw 2 CoreFoundation 0xf1024 __CFDictionaryCreateGeneric 3 WebKit 0x187180 WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker 4 WebKit 0x27cfb8...

[webview_flutter] iOS Flutter got crash because of [FLTWKNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:] was not called

@flutter-symbolizer-bot this force ios release arm64 flutter#v2.10.4 whatever ``` Fatal Exception: NSInternalInconsistencyException 0 CoreFoundation 0x99d78 __exceptionPreprocess 1 libobjc.A.dylib 0x16734 objc_exception_throw 2 CoreFoundation 0xf1024 __CFDictionaryCreateGeneric 3 WebKit 0x187180 WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker 4 WebKit...

[webview_flutter] iOS Flutter got crash because of [FLTWKNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:] was not called

> @mraleph why is that missing the `WebKit` part of the stack? Why does it show 14 Flutter frames when the original shows 2, then some CoreFoundation, then another 13...

[M1 Mac] When running apps on Android 6 emulators, the app throws the following message 'Unfortunately, flutter_app has stopped'

@gmackall The bot might not be feeling well, so my advice in these cases is to use [bot's CLI](https://github.com/dart-lang/dart_ci/blob/main/github-label-notifier/symbolizer/bin/symbolize.dart) instead. Though in this particular case I had to tweak the...

Improve the tools/process around tracking and minimizing technical debt

> https://github.com/flutter-symbolizer-bot, perhaps we could get @mraleph to do a tech talk :) I am happy to give a talk - but the most important experience I have currently is...

[BUG] ndk-stack does not accommodate for the difference in relative PC computation between Android versions

For the sake of completeness here is correction logic I ended up implementing myself to handle the difference (because I discovered that I can't rely on `ndk-stack`): https://dart-review.googlesource.com/c/dart_ci/+/168960/4/github-label-notifier/symbolizer/lib/symbolizer.dart#292 ```dart computePCBias:...

[BUG] ndk-stack does not accommodate for the difference in relative PC computation between Android versions

> android.googlesource.com/platform/system/unwinding/+/master/libunwindstack/AndroidVersions.md Oh, this is the sort of the document I was missing - would save me a lot of time figuring these myself by observation. > There is the...