hyper-command-gifs icon indicating copy to clipboard operation
hyper-command-gifs copied to clipboard

Published 20 hours ago • verified publisher icon mrMetalWood

Add Giphy Integration

Open SaraVieira opened this issue 7 years ago • 6 comments

Hello Malte,

I created this updated version of the plugins that has the Giphy API integration and searches a random gif with the tag the user wrote on Giphy and returns that gif as the BG image This PR also adds the timeout config. Also added some ESLint and deleted the gif.js file.

Does this sound like something you would like to merge ?

SaraVieira avatar Mar 01 '17 22:03 SaraVieira

Hello Sara,

thank you for your PR :)

First, I like the timeout option 👍

My first prototype used the Giphy API and I decided to move away from it. I felt like most GIFs I received from the API didn't really give me good results. Especially for keywords like test or checkout. So I moved to this curated list. And I'd like to keep that for now. However, I thought about the option for the user to add custom keywords for matching. And we could use the Giphy API for those custom defined keywords which don't have a list (yet)!?

As for the linting, I thought about trying something https://github.com/prettier/prettier in this project. There is often times so much discussion about eslint rules ;) I don't like the tabs too much for example. But this is completely my personal opinion.

mrMetalWood avatar Mar 04 '17 10:03 mrMetalWood

Hello,

Thank you do much for the reply and your opnion about giphy is pretty valid but I really enjoy the randomness in my case so do you mind if I keep this one, I made a publish to npm, crediting you as the original maker? I know a couple of guys here at work that would love the randomness too :p

As for the linting I could put the one you suggested with spaces :)

I'll create a pull request with just the linting, the timeout option and try add the custom words with giphy so you can merge that one,

Does that seem good to you? I'll create another fork :)

SaraVieira avatar Mar 04 '17 11:03 SaraVieira

Hey,

sure, you can publish your fork :) I can see your point.

Yes, that sounds good 👍

mrMetalWood avatar Mar 04 '17 11:03 mrMetalWood

Thanks Man 🎉

SaraVieira avatar Mar 11 '17 12:03 SaraVieira

Hey @mrMetalWood , @SaraVieira , Any update on this feature (add Giphy Integration). I personally like the idea of having random gifs each time.

So, I was wondering is this something I can start using at this point ? (given that this PR is not yet merged)

Kudos for mrMetalWood for the plugin and SaraVieira for this PR 🎉

sameera207 avatar May 17 '17 06:05 sameera207

Hey @sameera207,

When I left this if I remember correctly it was working great :)

Can you please try it ? If it does work great I'll put it up on NPM :D

SaraVieira avatar May 17 '17 22:05 SaraVieira