mqrause
mqrause
I think I just need to ask a maintainer to reopen it when I continue working on it.
I was about to submit a PR before thinking about checking if something like that was already in the works by someone. Specifically I wanted to remove the 1x multiplier...
`count_by_charges` items currently don't store their components, so they'll always fall back to default components. That's because there might be issues with distributing components evenly to charges. So there's two...
~~Not this one, but I added something to do that in #60885.~~ Actually no fixes for that included anywhere for now.
From what I can see your solution is trying to fix the wrong end of the issue. The `recipe_charges` are actually correct but the components assign only a single item...
Recipes have two advantages for the purposes of this. The first is that they essentially define the "conversion ratio" as a proper fraction with created items as the numerator and...
I didn't give it a real review, yet, just addressing the clang-tidy issues. > Untouched file, and that's not what's on that line, it's ` distance_player, is_dangerous ? "DANGEROUS AREA!"...
I like the recipe approach, I think that might be a potential first step in genericizing things like milling, smoking and other automated processing. Currently this causes new issues, though....
Yeah, a lot of the stuff is inconsistent (or outright bugged, which is why I made #71768 after reviewing this). But beware of scope creep. It's perfectly fine to just...
> There's also the issue that the test itself is buggy, since it doesn't complain about the same yield in the manual crafting recipes (5->15), for whatever reason (my guess...