Qasim Sarfraz
Qasim Sarfraz
> Sounds like a good reason to upgrade (I forgot if the Buildroot ISO has swap memory controller or not) > I believe the ISO do have swap memory controller....
> Anyway, it is enabled by default in recent kernels. Ah okay, got it! Just for understanding, would upgrading the version here also updates it for `docker` driver? Like kickbase...
It seems this is [affecting integrations runs](https://github.com/inspektor-gadget/inspektor-gadget/actions/runs/7844617994/attempts/1#summary-21407476104) on GKE (OS: `Container-Optimized OS from Google`, Kernel: `5.15.133+`) since I see following warnings in the log: ``` time="2024-02-09T13:38:05Z" level=warning msg="updating socket_file_ops address...
> What is the status of this PR? I did take a quick look but I can see there are still some previous unresolved comments. Thanks for the quick look,...
> How come? Did you start the tests manually? The `push` run is also [done in the CI](https://github.com/inspektor-gadget/inspektor-gadget/actions/runs/8391532394). I pushed the changes to [citest/alban_privatedata](https://github.com/inspektor-gadget/inspektor-gadget/tree/citest/alban_privatedata) as well and it seems GH...
> I have some questions on the tests. I fixed the test > But otherwise, LGTM if the CI passes on GKE and other platforms! Great, I will keep it...
> Are the current CI failure on AKS related to this PR? I am not sure, it seems CI is failing on [`main` as well.](https://github.com/inspektor-gadget/inspektor-gadget/actions/runs/8448407680). I will try to run...
Thanks for the reviews!
This looks painful: > Use --vpc-private-subnets & --vpc-public-subnets to avoid creating a new VPC for the cluster Why don't we go for this option? I mean we will have to...
> Thanks! Will this work also when #2448 is merged? IIUC this change only impacts `ig` which doesn't overlap with any changes made in #2448 (`WithInitialKubernetesContainers` and `WithhPodInformer` aren't used...