Michael Warres

That's an unfortunate collision, though I guess it isn't surprising. We can't simply switch to something like `PROXY_WASM_LOG` since that would break existing code. But maybe we could have a...

Thanks for the comments, PTAL

@PiotrSikora this is ready for another look. Thanks!

Updating the protobuf library should make the hack mentioned in [these instructions](https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/blob/3c7f786bf1e8bdd9537a640eeff1558e18bc9855/README.md?plain=1#L194-L211) obsolete, since protobuf added support for building with Emscripten in protocolbuffers/protobuf@8e869f7. As part of updating protobuf, the instructions...

Still looking, will finish review tomorrow. Sorry for the delay.

> Looks really good! WRT @alyssawilk question: > > > The one think I'm not sure of if there are the stream info setters - it looks like they could...

> @mpwarres any further thoughts? LGTM

Sorry for the delay and thanks for the nudge, this fell through the cracks. Thanks for the fix!

Windows and MacOS presubmits fail with: ``` In file included from external/com_google_googletest/googlemock/include/gmock/gmock.h:59: external/com_google_googletest/googlemock/include/gmock/gmock-actions.h:819:36: error: no type named 'result_of' in namespace 'std' using ReturnType = typename std::result_of::type; ~~~~~~~~~~~~~~^~~~~~~~~ external/com_google_googletest/googlemock/include/gmock/gmock-actions.h:819:45: error: expected...

Repro of g++-specific compile error with variadic templates, which compiles successfully with -std=c++17 but not with -std=c++20: https://godbolt.org/z/TT9a9YPf7