Objective-Smalltalk icon indicating copy to clipboard operation
Objective-Smalltalk copied to clipboard

README.md build instructions implicitly depend on `testlogger`, from MPWTest?

Open mstone opened this issue 3 years ago • 2 comments

Checking out Objective-Smalltalk, MPWFoundation, selecting the 'stsh' scheme, and hitting build results in the following error:

...
    /bin/sh -c /Users/mstone/Library/Developer/Xcode/DerivedData/objective-smalltalk-ennpizgpendiubaaqiihhtetjsas/Build/Intermediates.noindex/MPWFoundation.build/Release/MPWFoundationFramework.build/Script-1FF8FE2809B49D0200652476.sh
---
/Users/mstone/Library/Developer/Xcode/DerivedData/objective-smalltalk-ennpizgpendiubaaqiihhtetjsas/Build/Intermediates.noindex/MPWFoundation.build/Release/MPWFoundationFramework.build/Script-1FF8FE2809B49D0200652476.sh: line 7: /Users/mstone/Library/Developer/Xcode/DerivedData/objective-smalltalk-ennpizgpendiubaaqiihhtetjsas/Build/Products/Release/MPWFoundation.framework: is a directory
Command PhaseScriptExecution failed with a nonzero exit code

Further printf-debugging in the script of the Test build phase of the MPWFoundationFramework target suggests that this may be due to tester=`which testlogger` failing to find testlogger in my PATH.

As for what to do: should MPWTest / testlogger be listed in the README as a required dependency, if the default build cannot complete without it?

(or, even better, can the default build configuration cause it to be built if needed without further developer intervention?)

Thanks!

mstone avatar Jun 06 '21 19:06 mstone

Thanks for the heads-up!

This is supposed to be a soft dependency, meaning if you have MPWTest/testlogger installed on your system it runs the tests. If you don't, it just issues a warning that tests aren't being run. At least that's how it's supposed to work, and used to work, but now that logic appears to be broken.

I am in the process of fixing it (and may just fold a slimmed-down MPWTest into MPWFoundation), but the easiest workaround for now is to either remove that build phase or disable it by checking the "For install builds only" checkbox.

mpw avatar Jun 08 '21 10:06 mpw

@mpw how is that going?

sebastianconcept avatar Aug 13 '22 18:08 sebastianconcept