Marcel van Lohuizen

Results 151 comments of Marcel van Lohuizen

I see. So what I observe going on here is that the input of the two users is resolved to be self-contained without references (like an OpenAPI equivalent) to be...

@leejanee: CL https://review.gerrithub.io/c/cue-lang/cue/+/528214 hints at a solution where we could do an expansion where we include definitions outside of scope (e.g. from imports) as top-level let expression in the evaluation...

And just to confirm: it is not sufficient for you to use, for instance, the `cue.Final()` option. This would also simplify defaults and close lists.

I'm making good progress with the `SelfContained` option. It's quite involved but getting there. :) A few more edge cases to be handled, like aliases and references to parent nodes...

Here you can find a first implementation: https://review.gerrithub.io/c/cue-lang/cue/+/541464/3. There is a new test set where you can see some of the logic behind it. Note that the current implementation assumes...

BTW, one edge case that this implementation does not yet support is if the value for which `Syntax` is used contains references to ancestor nodes (thus recursively referring to that...

Also, referenced values that cannot be inlined are currently represented as hidden fields. These really should be `let` expressions. I may still do that.

> #1816 one more case, maybe it's also related with the selfcontained and can be resolved together. It indeed solve it, to some extent, but please see my answer there....

Even with performance problems fixed, as long as there are comprehensions, it is easy to construct something that will taken an inordinate amount of time. So supporting cancellable evaluation is...

Unfortunately, the fix was breaking too much other code. We already knew this was a brittle change. We now plan to fix this as part of an evaluator revamp. This...