mpv icon indicating copy to clipboard operation
mpv copied to clipboard

Published 20 hours ago • verified publisher icon mpv-player

DOCS: document P3-D65 primaries and two missed in format

Open ValZapod opened this issue 3 years ago • 10 comments

display-p3 was undocumented and EVERYONE somehow uses dci-p3 with funny DCI whitepoint, that no one should target and no iPhone photo uses! Oogh.

ValZapod avatar Jan 25 '22 16:01 ValZapod

as https://github.com/mpv-player/mpv/issues/9620#issuecomment-1021971768. --target-prim is primary only, doesn't matter what tfc, wp, cct it is. rather than call it display p3, i'd like to call it dci-p3-d65 https://en.wikipedia.org/wiki/DCI-P3#System_colorimetry

natural-harmonia-gropius avatar Jan 26 '22 08:01 natural-harmonia-gropius

Commits should be squashed

haasn avatar Jan 26 '22 14:01 haasn

rather than call it display p3, i'd like to call it dci-p3-d65

We cannot: this is part of public API now. What is done is done. See https://github.com/mpv-player/mpv/pull/5236#issuecomment-351904328

Anyway, squashed and addressed comments. I WILL ADD white points to those two places, sorry. BTW, is there a way to give any white point and primaries to it??? Like Little CMS should not care, does it not??

Also WTF is that??

https://github.com/mpv-player/mpv/blob/6265724f3331e3dee8d9ec2b6639def5004a5fa2/video/csputils.c#L942-L946

ValZapod avatar Jan 27 '22 04:01 ValZapod

Change seems fine to me

haasn avatar Jan 27 '22 12:01 haasn

BTW, I did check that bt.470m/s-gamut/display-p3 all work for vf format. And no, they are not the same with others in format and yes they do have a perfect roundtrip when format is the same as target. gpu only, gpu-next is not really working with format at least.

ValZapod avatar Jan 27 '22 15:01 ValZapod

@jeeb Please merge.

ValZapod avatar Feb 02 '22 22:02 ValZapod

Any update on this? I'm interested in having the display-p3 option.

quietvoid avatar Mar 03 '22 14:03 quietvoid

Any update on this? I'm interested in having the display-p3 option.

The option already exists. This patch just adds the manpage entry for it.

I will probably merge it eventually. Some day. I think @ValZapod is pushy enough with his comments that he can learn to wait.

haasn avatar Mar 03 '22 15:03 haasn

Oh okay, I thought it wasn't being passed to VOs. Thanks.

quietvoid avatar Mar 03 '22 15:03 quietvoid

comments that he can learn to wait.

I cannot see your comment. looks like you forgot you blocked. Hilarious.

ValZapod avatar Mar 03 '22 22:03 ValZapod