mpv icon indicating copy to clipboard operation
mpv copied to clipboard

dither green pattern

Open geextahslex opened this issue 1 year ago • 8 comments

Hi I use dither (dither-depth=8 dither=fruit) It helpfs fixing artifacts etc. but it also introduces this weird green pattern which in itself prevents from ever having any real black on screen. What are your thoughts on this? are you using dithering? Is there any better technique? Do you also notice this in dark scenes?

Thanks for any suggestions :)

Screenshots, boosted luminance for demonstration purpose. dither off dither off 11 dither on dither on 111

geextahslex avatar Apr 14 '24 09:04 geextahslex

We solved a similar problem for deband grain, which turns itself off near black to avoid exactly this noise. Probably should do the same for dithering.

haasn avatar Apr 14 '24 10:04 haasn

If its not compromising the visual quality, this sounds good. You loose actually the benefit of having an OLED screen, for obvious reasons.

geextahslex avatar Apr 14 '24 10:04 geextahslex

dither inferno dither apocalypse

geextahslex avatar Jun 05 '24 21:06 geextahslex

Looks correct, no? What is it 2 or 3 bits?

kasper93 avatar Jun 05 '24 22:06 kasper93

Source is 10 bits (4kHDR) my TV is 8 bits (SDR) my setting is dither-depth=8 dither=fruit

I have found an article about dithering https://blog.frost.kiwi/GLSL-noise-and-radial-gradient here is a screenshot, looks nice and clean screenshot_gradient_dither

geextahslex avatar Jun 05 '24 22:06 geextahslex

my setting is dither-depth=8 dither=fruit

Sorry, but I don't believe you. It is not possible to produce such dither pattern targeting 8-bits.

You need to state what is your problem and provide full reproduction steps with config and all the shaders you use.

Also this might be the case of https://xyproblem.info/ so please state your issue and current state of solving that issue.

kasper93 avatar Jun 05 '24 22:06 kasper93

Sorry, but I don't believe you. It is not possible to produce such dither pattern targeting 8-bits.

but haasn stated above that

"We solved a similar problem for deband grain, which turns itself off near black to avoid exactly this noise. Probably should do the same for dithering."

I'm not sure what you mean by that. As I mentioned above "Screenshots, boosted luminance for demonstration purpose." to make it better visible.

state what is your problem

(as mentioned above) dithering introduces this weird green pattern/green dots in shadow/dark areas which in itself prevents from ever having any real black on screen.

full reproduction steps

watch 4k 10bit source on 8bit sdr monitor/tv with dither-depth=8 dither=fruit

I checked also a SDR 4k 10bits file to avoid using tonemapping, but it also has this pattern. This is raw mpv without any external glsl shaders etc.

dither1sdfsdf dither1 wewe

I can provide a logfile etc. if that helps

geextahslex avatar Jun 05 '24 23:06 geextahslex

zuzuz zuzuz2

geextahslex avatar Jun 06 '24 21:06 geextahslex

@kasper93 is there any update or change or is it just closed?

geextahslex avatar Aug 20 '24 09:08 geextahslex

Issues tracker is not for discussions/questions, I've opened the other issue #14319.

kasper93 avatar Aug 20 '24 09:08 kasper93