mpv
mpv copied to clipboard
mpv-player
Make hidpi-window-scale=no as default
It is almost never wanted that videos are blown up to twice their native image resolution and then have mpv play make believe that that is indeed the correct video resoltuion. hidpi means that the content rendered within that window is being rendered at a higher resolution than the native "dot size". Videos fundamentally don't do this however as you have to engage in upscaling so are not hidpi content.
Other problems this causes is for example when trying to window a 4k video on a 4k monitor being run as a hidpi "1080p" monitor they get blown up to effectively 8k in size because mpv thinks its a 1080p screen. Alternatively, playing a 1080p video on a 4k monitor with some window managers results in a "windowed" video that's still filling up the full screen instead of being a small window at only 1/4th the screen size.
This type of behavior is just never wanted.
Expected behavior of the wanted feature
Restore previous default behavior where windows were naturally are the same size as the video content.
I do actually prefer not doing hidpi scaling on mpv as well and find it annoying. This has been the default for a very long time though with relatively little complaining, so I assume a significant amount of people like it.
so I assume a significant amount of people like it.
I think most either just don't notice it or perhaps they don't care because they do most of their content consumption in fullscreen where the setting doesn't matter.
As an user my opinion is that having it turned on by default makes no sense whatsoever for a video player. A 1920x1080 video is still a 1920x1080 video regardless of DPI scaling.
On win32, both VLC and mpc-hc don't do this scaling. So at least it should be disabled by default on win32. But apparently the expected behavior is different on macOS (https://github.com/mpv-player/mpv/issues/3716#issuecomment-255819187), so the issue is a little complicated, and the option may need platform-dependent default.
The option was original implemented in https://github.com/mpv-player/mpv/pull/3725, which only concerns macOS. It seems that there are some confusion regarding the rationale behind this option about undoing the compositor scaling and virtual and physical pixels. But the compositor scaling should be always undone anyway, so this option only serves to preserve the "physical" window size, which isn't always desired as stated above.
I think macOS is the only odd one out here. Wayland used to be more like macOS with regards to scaling, but eventually all of that changed to be more like X11 and Windows.
just my personal preference. since the day i originally opened the PR and it was merged i use --hidpi-window-scale=no, because for me it's the only 'right' way to it. i didn't want my personal preference to interfere with the 'style guides and recommendations' from Apple. personally i wouldn't mind to default to no, though i can't and don't want to speak for other macOS users.
maybe on a side note, if we really want to do it properly i believe we need to kill this option and do something i suggested here https://github.com/mpv-player/mpv/issues/5688. we need to make all the geometry/size related options and features point aware.
I use on both MacOS and Linux. I complained about it the moment the functionality changed and got an angry reply from wm4 way back when I believe. It is absolutely absurd even on MacOS and the only reason it's different on Apple because Apple wraps all their video players with UI elements and they want the UI elements to be the same size across all systems. mpv doesn't have UI elements that need to be the same size so it makes no sense. I wrote this feature request not expecting to get much traction, but now that it's being a pain on more users than just MacOS users who generally don't care about this kind of thing (for reasons I find confusing) I'm glad that some sanity is taking hold (along with wm4 going away).