mpv icon indicating copy to clipboard operation
mpv copied to clipboard

Published 20 hours ago • verified publisher icon mpv-player

vo_gpu_next: render subtitles at video colorspace

Open kasper93 opened this issue 1 year ago • 2 comments

Ref: https://code.videolan.org/videolan/libplacebo/-/merge_requests/630

kasper93 avatar Feb 01 '24 15:02 kasper93

Needs to not apply to SRT subs, which definitely shouldn't be rendered out as HDR. For this, SOME amount of internal metadata plumbing is necessary so mpv can later decide whether a subtitle came from ASS, PGS or SRT.

haasn avatar Feb 01 '24 17:02 haasn

I know, that's why it's still a draft. Just dropping a PR as a good-faith and to force myself to finish it sooner than later.

kasper93 avatar Feb 01 '24 17:02 kasper93

Best I can do is this. If sub is unconverted ASS it will be interpreted as video csp. For the rest it stays sRGB. Also OSC for compatibility is sRGB.

EDIT: Note this still needs https://code.videolan.org/videolan/libplacebo/-/merge_requests/630 to work correctly, but it is not a blocker, as the change is improvement either way.

kasper93 avatar Feb 27 '24 01:02 kasper93

Download the artifacts for this pull request:

Windows
macOS

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Seems reasonable enough.

haasn avatar Feb 27 '24 12:02 haasn