mpv icon indicating copy to clipboard operation
mpv copied to clipboard

Published 20 hours ago • verified publisher icon mpv-player

{common,player}: version logging changes

Open jeeb opened this issue 2 years ago • 1 comments

  1. Adjust the location of the overall FFmpeg version logging.
  2. Add libplacebo version as part of --version.

jeeb avatar Nov 13 '22 12:11 jeeb

Maybe introducing a whole new symbol MP_PL_VERSION is a bit unnecessarily verbose (as opposed to just having the #ifdef check at the usage site), but I don't particularly have a preference.

Technically I could have defined PL_VERSION but I thought that goes over onto the libplacebo namespace and thus MP_PL_VERSION it was in this attempt.

jeeb avatar Nov 13 '22 17:11 jeeb

Reverted to the #if HAVE_LIBPLACEBO at usage site solution since people seemed to prefer it to having all the pre-processor stuff on top of the file.

Just thought it made sense to have it in a single location, esp. if in the future libplacebo becomes an integral part of mpv.

jeeb avatar Nov 14 '22 22:11 jeeb