mpv icon indicating copy to clipboard operation
mpv copied to clipboard

RFC: remove waf

Open LaserEyess opened this issue 3 years ago • 2 comments

The rationale behind this is in the commit message but I'd just like to additionally add that I've found it confusing to support a second build system that requires me to write a bunch of error-prone NIH code that meson does for me automatically.

This is a RFC, partially to make sure I didn't mess up the CI, and to get feedback.

LaserEyess avatar Nov 12 '22 14:11 LaserEyess

mingw run:

Warning: No files were found with the provided path: mpv-git-*.zip. No artifacts will be uploaded.

libmpv/mpv.def is also only used by waf

sfan5 avatar Nov 12 '22 14:11 sfan5

Too early for this but eventually it would be nice to remove waf. Just FYI, most of the code fragments (iconv.c, etc.) are unused in meson.

Dudemanguy avatar Nov 12 '22 16:11 Dudemanguy

By the way, I remembered that libmpv/client.h has a /* New symbols must still be added to libmpv/mpv.def. */ comment that you can remove too.

Dudemanguy avatar Jul 23 '23 17:07 Dudemanguy