mpv icon indicating copy to clipboard operation
mpv copied to clipboard

Documentation not clear for "sub-ass-styles"

Open j77h opened this issue 2 years ago • 2 comments

From https://mpv.io/manual/master/

--sub-ass-styles=<filename>
 
    Load all SSA/ASS styles found in the specified file
    and use them for rendering text subtitles.

From my efforts to get this to work, I think the last line should say "ASS" instead of "text": and use them for rendering ASS subtitles, followed by this extra line: when sub-ass-override is set to yes.

I did not find any way to get --sub-ass-styles=<filename> to influence the rendering of subtitles from SRT or VTT files.

I'm reporting as if the document is at fault, but you might conclude that this feature should operate on non-ASS text files, which is what the document led me to expect.

j77h avatar Nov 11 '22 07:11 j77h

You might want to clarify what you mean by this.

Your choice of explanation is slightly confusing; do you mean to say that the explanation of how MPV handles SSA/ASS subtitle styles isn't well clarified?

DreamHollow avatar Nov 13 '22 02:11 DreamHollow

do you mean to say that the explanation of how MPV handles SSA/ASS subtitle styles isn't well clarified?

Nothing so broad as that.

Simply that sub-ass-styles followed by "for rendering TEXT subtitles" seems to mean that sub-ass-styles can be used to style non-ASS kinds of subtitle file (SRT, VTT, etc).

But it doesn't work that way, it applies only to ASS files. (Only when sub-ass-override is set to yes, naturally.)

j77h avatar Nov 13 '22 03:11 j77h

P.S. if you want to open a PR to improve the wording, feel free.

Dudemanguy avatar Jan 09 '23 15:01 Dudemanguy