mpv icon indicating copy to clipboard operation
mpv copied to clipboard

cannot change sub height after toggling sub-ass-override=force

Open AdventurerRussia opened this issue 2 years ago • 16 comments

Important Information

after enabling sub-ass-override "force" and then I changed the height of the subtitles and as I switched back to the original design of the ass subtitles, their position was reset and it became impossible to change their height when their design is original. I recorded a video of how it happens https://youtu.be/ASDhD5drp6E

  • Platform and Version Выпуск Windows 11 Pro Версия 22H2 Дата установки ‎22.‎10.‎2022 Сборка ОС 22621.755 Взаимодействие Windows Feature Experience Pack 1000.22636.1000.0

  • Source of the mpv binary last build from here https://sourceforge.net/projects/mpv-player-windows/files/64bit-v3/

If you're not using git master or the latest release, update. Releases are listed here: https://github.com/mpv-player/mpv/releases

AdventurerRussia avatar Nov 06 '22 07:11 AdventurerRussia

Cannot reproduce and where is your log?

I switched back to the original design of the ass subtitles

This is an ambiguous statement. sub-ass-override=no ? yes (default)? or scale ? And you shouldn't use no if you want sub-* options works for ASS subtitles.

hooke007 avatar Nov 06 '22 15:11 hooke007

It sounds like they're saying the keybind to increase/decrease sub height stops working after toggling sub-ass-override=force on and off (also can be done with a keybind).

Traneptora avatar Nov 06 '22 15:11 Traneptora

It sounds like they're saying the keybind to increase/decrease sub height stops working after toggling sub-ass-override=force on and off (also can be done with a keybind). yes that's right

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

Still cannot reproduce and log?

hooke007 avatar Nov 06 '22 18:11 hooke007

If you were using the built-in shortcuts. That's not a bug. https://github.com/mpv-player/mpv/blob/25906514c3aec87589833043f6281584946c98b4/etc/input.conf#L126

As I said, you shouldn't use no. Try yes instead.

hooke007 avatar Nov 06 '22 18:11 hooke007

Still cannot reproduce and log?

Still cannot reproduce and log?

I didn't add anything to the config file at all, I just downloaded a clean build and showed that by default, when changing the style to the u key, then after returning to the subtitles style, it is impossible to move it down or up. here I was preparing a log I'm sorry for the delay https://fex.net/ru/s/fxmyerr

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

The built-in shortcuts is not suitable for your case. Add the command as I said and rebind it to one <key>.

hooke007 avatar Nov 06 '22 18:11 hooke007

I mean, why does it not come out after switching to the u key and returning back to shift the subtitles, and also why they are reset to the default location, and not the value that I raised or lowered using the r and t keys

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

Because the default value is yes. More details you could get from doc.

https://mpv.io/manual/master/#subtitles

Subtitles in ASS format are normally not changed intentionally, but overriding them can be controlled with --sub-ass-override.

https://mpv.io/manual/master/#options-sub-ass-override

hooke007 avatar Nov 06 '22 18:11 hooke007

I went through all the options for the --sub-ass-override= key, and still after switching to the original style of subtitles, and not that mpv can't move them, and after restarting the player, they can't be moved either. Only if you specify --watch-later-options-remove=sub-ass-override, then everything works after reboot,

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

it would be fine if they cannot be moved while the player is running, but after a reboot it is also impossible if the save file browsing history option is specified.

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

You just need to add

u cycle-values sub-ass-override "force" "yes"

into you input.conf.

And then click it to re-activate yes.

hooke007 avatar Nov 06 '22 18:11 hooke007

u cycle-values sub-ass-override "force" "yes"

so I'm sorry that I took your time, everything is working as it should now, but honestly, this logic of subtitles looks like a bug. and the key parameter that you gave me looks like it should work in the player by default. thanks again for your time. I have no right to tell you, but maybe it's worth doing a survey about the behavior of subtitles. Because the way it now works by default is very strange.

AdventurerRussia avatar Nov 06 '22 18:11 AdventurerRussia

The options in watch_later cache files would be applied after the loading of every file. While the options in mpv.conf were set when starting the mpv. As a personal advice, you could use the 'whitelist' (i.e. watch-later-options=aid,sid ) to only save the properties you like.

hooke007 avatar Nov 06 '22 18:11 hooke007

It is indeed a bug if toggling it on and off removes the functionality.

Traneptora avatar Nov 06 '22 20:11 Traneptora

I don't see any bug here. no works as its desciption. The only question is why the built-in shortcut only cycles between no and force. related https://github.com/mpv-player/mpv/issues/6607

hooke007 avatar Nov 06 '22 20:11 hooke007