mpv-android icon indicating copy to clipboard operation
mpv-android copied to clipboard

Port Main Screen To M3

Open khaled-0 opened this issue 1 year ago • 16 comments

This will be porting everything else except for Player

khaled-0 avatar Dec 07 '24 14:12 khaled-0

image

khaled-0 avatar Dec 07 '24 18:12 khaled-0

@Marco-9456 look

khaled-0 avatar Dec 07 '24 18:12 khaled-0

the legacy file picker is really legacy it barely works on newer api

@sfan5 should I push a MediaStore based impl in this pr?

khaled-0 avatar Dec 10 '24 01:12 khaled-0

Fuckit im doing MediaStore. the legacy fp sucks ass

khaled-0 avatar Dec 14 '24 08:12 khaled-0

mediastore ano nee image

khaled-0 avatar Jan 04 '25 08:01 khaled-0

@khaled-0 Well done!

Marco-9456 avatar Jan 04 '25 09:01 Marco-9456

I have no idea about how I should implement the filepicker. So I'll stop here now with my initial mediastore implementation image while I have some idea about what I should implement, I have no inspirations / code to follow here for inspiration. So I'm waiting for some expert suggestions

khaled-0 avatar Jan 12 '25 12:01 khaled-0

@khaled-0 check the Figma file

Marco-9456 avatar Jan 12 '25 12:01 Marco-9456

@sfan5 should I push a MediaStore based impl in this pr?

If it's superior the "open document dir" thing could be replaced with MediaStore, but I'd prefer if this PR is design changes only (if possible). I know the old file picker stuff is terrible. If there's no other way we could leave it as legacy Material for now.

Also, please rebase/conflict resolve this PR.

sfan5 avatar Jan 13 '25 20:01 sfan5

@khaled-0 could you rebase this if you have time? I plan to review it next.

sfan5 avatar Feb 06 '25 16:02 sfan5

@khaled-0 could you rebase this if you have time? I plan to review it next.

yeah I finally got some time, and planning to complete the player (only menu left) will rebase this too hopefully in a day or two

khaled-0 avatar Feb 07 '25 09:02 khaled-0

It reset the commit history but oh well, rebased

khaled-0 avatar Feb 08 '25 06:02 khaled-0

https://github.com/user-attachments/assets/0c1525f7-f45d-4240-8d35-31468ad8358a

This probably needs to be fixed. It appears after on/off Material you toggle in General settings.

dexaltat avatar Feb 13 '25 21:02 dexaltat

please merge!

SonaliBendre avatar Mar 09 '25 09:03 SonaliBendre

@sfan5 Sorry to bother you, but could you clarify the situation with the PR regarding the redesign? Everything has been at a standstill for a long time. Is a merge planned?

dexaltat avatar Nov 07 '25 19:11 dexaltat

I still plan to look at the redesign PRs by @khaled-0 and incorporate them.

sfan5 avatar Nov 08 '25 10:11 sfan5