Mateusz Pusz
Mateusz Pusz
Hi @JohelEGP, it would be great to merge this PR but there are still some unresolved issues we discussed above.
The CI needs fixing as well. We should probably add modules tests to CI as well to check if there are no issues in the PR. Which compilers should the...
> Looks like Clang 16 can't be used to test the modules. I got the info from the Conan team that Conan 2.0.12 should appear today and will have fixes...
clang-17 support added with https://github.com/mpusz/mp-units/commit/92b7069c35bba592743c1132c4c2eccfa9c59c6c.
WOW!!! This is so awesome! 🎉
Please let me know when you will think it is ready to merge (i.e. in case you want to provide those toolchain files for CMake).
I am still looking for the best modules structure for the project. There are a few alternatives: # The simplest one ```mermaid flowchart TD mp_units --- systems --- core mp_units...
I personally like the first one the most. It is the simplest one and allows selective inclusion of all the options.
We could consider breaking the project into even smaller pieces, but I am unsure if it makes sense to provide separate modules for each system. It could lower the module...
@jcar87, could you please help @JohelEGP with his issues with Conan support for modules? We would like to merge this to the mainline ASAP.