Marius Poke
Marius Poke
> * Write out bytes, e.g. `[]byte{0x04}` Having a single `keys.go` file with all the keys can enable also this solution. We could check then that all the keys are...
What about using a constant map? ```golang func getKeyPrefix() map[string]byte { return map[string]byte{ "PortByteKey": 0, "MaturedUnbondingOpsByteKey": 1, "ValidatorSetUpdateIdByteKey": 2, } } func PortKey() []byte { return []byte{getKey("PortByteKey")} } ``` Like...
Reopening issue to deal with consumer changes.
Message from @colin-axner > In ibc-go the main difference is that core IBC will revert all application state changes if an error acknowledgement is returned. Other than that, the acknowledgement...
> Doesn't an error ack close the channel? AFAIK, not in the IBC module. Only if we close it on the application side (i.e., in the OnAck code).
> I think a while ago in a WIP PR I accidentally returned an error and it automatically closed the channel. This is due to the code [here](https://github.com/cosmos/interchain-security/blob/0c62722c4c8ac138ff795a9b09f9125da3ed2bd7/x/ccv/consumer/keeper/relay.go#L203) or [here](https://github.com/cosmos/interchain-security/blob/0c62722c4c8ac138ff795a9b09f9125da3ed2bd7/x/ccv/provider/keeper/relay.go#L112)....
> This means that a delegator D can delegate to V at any height in the interval `[hi, h-1]` and as a result get slashed at height h for the...
Closing issue for now.
@albttx Thank for the contribution. I have some concerns with the proposed solution. Benefits of the existing protocol: - The default action is to have the collateral (that enables validators...
As a side note, to avoid the delays stacking up, each VSCPacket should have the timestamp of when the provider sent it. Under the assumption that the clock drift is...