Mario Minardi
Mario Minardi
@oscar-b FYI closing this out as its been addressed in https://github.com/tailscale/gitops-acl-action/pull/67
Hey @lmagyar, thanks for the PR and apologies for the miss on the initial changes! Are you able to push an amended commit that contains `Fixes: #15552` in the commit...
> I'm done it now, I'm sorry, I missed the check message. No worries! Removing the `"tailscale.com/hostinfo"` import from `envknob/featureknob/featureknob.go` should resolve the errors in the tests.
As more of a nitpicky item: are you also able to format the commit message following the guidelines mentioned [here](https://github.com/tailscale/tailscale/blob/main/docs/commit-messages.md#commit-messages)? E.g., something like: `envknob/featureknob: Restore SSH and exit-node capability for...
> Finally I've tried to follow all the requirements. Thank you for your patience! Thank you, things are looking good to me overall now! And thank you as well for...
@rubensf thank you for flagging this! Working on a fix at the moment. On another note: we actually add a rule for matching against the audience / `aud` claim under...
Closing this out since this has been released! See https://tailscale.com/kb/1581/workload-identity-federation for further docs here.
Thanks for flagging this @gz ! We're aware that this (and debugging incorrect setup in general) is a rough edge currently for workload identity and are looking at improving this.
Hey @hckhanh ! Is this something you are still seeing? Was not able to reproduce when using the cache today, potentially something on GitHub's end? Looks like there is also...