pfft icon indicating copy to clipboard operation
pfft copied to clipboard

use embeded fftw3 as a subpackage

Open rainwoodman opened this issue 10 years ago • 6 comments

This hugely simplifies the building process of pfft. Since the new planners are unlikely to be included in next release of FFTW in any short term, it makes sense to just ship in a release the patched version of FFTW that is known to work with PFFT.

This currently requires --enable-mpi on the configure scripts. threading support is untested.

rainwoodman avatar Jul 07 '15 22:07 rainwoodman

Thank you for the patch. I will have a look on it. However, it might be a bit more difficult, since PFFT is also a submodule of PNFFT and ScaFaCoS. ScaFaCoS comes with its own FFTW clone -- but there we must prefix all FFTW functions with fcs_fftw_ in order to avoid linking errors.

I have to think of a nice approach that allows PFFT to come with its own FFTW and PNFFT to come with its own FFTW and PFFT. The solution must be compatible with ScaFaCoS, that comes with its own FFTW, PFFT and PNFFT. In addition, it should be possible that the user provides its own versions of the dependencies via CFLAGS and LDFLAGS.

mpip avatar Jul 08 '15 06:07 mpip

Any ideas are appreciated.

mpip avatar Jul 08 '15 06:07 mpip

May I ask why PFFT has a FFTW, PNFFT has another FFTW, and ScaFaCoS has a third FFTW? What is the difference between these FFTWs?

rainwoodman avatar Jul 08 '15 17:07 rainwoodman

FYI, a requirement on a patched version of FFTW would seriously hinder any attempts to package these pieces of software for Linux.

ghisvail avatar Jul 08 '15 18:07 ghisvail

on the PFFT side, an alternative is to give FFTW the ability to accept additional planners. That may be easier to get accepted than, supplying with new planners that FFTW upstream doesn't make use of.

What customization to FFTW does PNFFT and ScaFaCoS require?

rainwoodman avatar Jul 08 '15 18:07 rainwoodman

I agree with @ghisvail -- was bitten by this before.

rainwoodman avatar Jul 08 '15 18:07 rainwoodman