pfft icon indicating copy to clipboard operation
pfft copied to clipboard

local_start of 'empty' ranks is inconsistent.

Open rainwoodman opened this issue 9 years ago • 3 comments

The local_start of an empty rank is always set to 0. This is causes unnecessary branching in downstream code. The logical model is simpler if we just think of these 'stencils' as with a size of zero, but offsetted the same way as others.

For example the local_i_start of a 3d r2c transform on a 2x53 domain decomposition(this set-up is sub-optimal) is currently:

([   0,  512]),
([   0,   20,   40,   60,   80,  100,  120,  140,  160,  180,  200,
        220,  240,  260,  280,  300,  320,  340,  360,  380,  400,  420,
        440,  460,  480,  500,  520,  540,  560,  580,  600,  620,  640,
        660,  680,  700,  720,  740,  760,  780,  800,  820,  840,  860,
        880,  900,  920,  940,  960,  980, 1000, 1020,    0]

I would suggest to change the last 0 to 1020.

rainwoodman avatar Dec 06 '15 20:12 rainwoodman

Sorry, I meant 1024 not 1020.

rainwoodman avatar Dec 06 '15 22:12 rainwoodman

This is the way FFTW did it for years. But I do not have any problems with your suggestions. I'll give it a try in branch block_offset. It will be merged into master after some tests.

mpip avatar Dec 21 '15 22:12 mpip

Thanks!

rainwoodman avatar Dec 28 '15 04:12 rainwoodman