react-native-context-menu-view icon indicating copy to clipboard operation
react-native-context-menu-view copied to clipboard

Published 20 hours ago • verified publisher icon mpiannucci

Add custom ID property

Open xmflsct opened this issue 2 years ago • 6 comments

Tried all libraries, love this the most. But without a custom ID property, it is almost impossible to manage a dynamic list easily when on press. Therefore added custom ID.

xmflsct avatar Jun 06 '22 19:06 xmflsct

Good stuff, thanks for sending. Does this make id always required? Meaning if someone upgrade la their version and has not set an if explicitly for their actions will it crash? Maybe we could default the is to the index unless otherwise specified?

mpiannucci avatar Jun 06 '22 22:06 mpiannucci

@mpiannucci good point. I am not an expert in native code (that is why I am using React Native). I did test that what if I don't supply id in RN. For iOS, then a system generated id will be returned. Maybe you can suggest edits to the native code of how to properly make id not required so it is not breaking?

xmflsct avatar Jun 07 '22 17:06 xmflsct

Ill take a look this week

mpiannucci avatar Jun 07 '22 18:06 mpiannucci

Hello, any news about this PR? I'd like to be able to use custom IDs as well, mainly for i18n issues 😇

ZRunner avatar Jul 07 '22 13:07 ZRunner

Hello, any news about this PR? I'd like to be able to use custom IDs as well, mainly for i18n issues 😇

Sorry!! busy times, ill try and set aside some time this weekend

mpiannucci avatar Jul 07 '22 13:07 mpiannucci

Hey @mpiannucci ! Is there any chance we could get some momentum on this PR? Our project would greatly benefit from it. If there's anything I can do to help, let me know!

fobos531 avatar Aug 09 '22 15:08 fobos531

Closing this PR as I have moved to another library.

xmflsct avatar Dec 06 '22 14:12 xmflsct