Manuel Pégourié-Gonnard

Great, thanks!

It's hard to validate correctness (are we using the correct format? computing the expected value for the shared secret? etc), not just for this PR, but for the entire EC...

Note: this will need rework once the I/O format of `psa_pake_input/output()` has been fixed to match the spec, as done in https://github.com/Mbed-TLS/mbedtls/pull/6390

I had a read-through and left some notes, nothing major I think. I really like the split between `start` and `complete`, which I think avoids a lot of problems in...

Ah, just thought of more things right after posting my last comment. Is the global setting `max_ops` a good idea? Shouldn't this be per operation instead, like one of the...

Note however that making `max_ops` not a global setting would create a mismatch with the existing Mbed TLS implementation and API. However, I don't think that should prevent use from...

I've been thinking: on one hand, providing `max_ops` as an argument to `start()` has a lot going for it, as it's the point where you also pass the key, which...

Hi @naynajain ! Regarding the CI failures, unfortunately the results are no public yet except for Travis, so the error you're getting is fully expected. We have plans for a...

Thanks for fixing those failures! The remaining failures seem to only happen on windows and to be related to this PR, as `test_suite_pkcs7` is failing with: ``` PKCS7 Signed Data...

Thanks for fixing those failures. The remaining failures now happen later, so we seem to be making progress: ``` 65/86 Test #65: pkcs7-suite ............................***Failed 0.02 sec PKCS7 Signed Data Parse...