pannellum icon indicating copy to clipboard operation
pannellum copied to clipboard

add types for typescript

Open dbwodlf3 opened this issue 3 years ago • 2 comments

I added types for typescript. I would like to devlop in typescript env.

I know pannellum is not commonjs working. it works only on browser.

It doesn't work in commonjs but anyway i can get typehinting

dbwodlf3 avatar Dec 23 '21 06:12 dbwodlf3

The index.d.ts file looks like it was automatically generated. How was this done?

My tendency is to not merge this as is, since it is an additional maintenance burden for something I don't use and am not in a position to test. Furthermore, the comments are all copied into an additional file and need to be maintained in two places. If there's a straightforward way to automatically generate the types, I'd consider including such a script, the output of which could potentially be included in releases, similar to how the minified files are generated for releases. However, the lack of testing would still be an issue.

mpetroff avatar Dec 26 '21 21:12 mpetroff

actually it is written by hand. i will find and update it (automated index.d.ts from source code).

dbwodlf3 avatar Dec 27 '21 01:12 dbwodlf3