Michael Penkov

Results 35 issues of Michael Penkov

#### Problem description Be sure your description clearly answers the following questions: - What are you trying to achieve? - What is the expected result? - What are you seeing...

enhancement

This is still a work in progress. I'm playing around with the idea to see if it's worth it.

_Originally posted by @mpenkov in https://github.com/RaRe-Technologies/smart_open/issues/593#issuecomment-804399314_

housekeeping

I disabled the HTTP tests because they seem to be failing on Travis now. Will investigate separately. _Originally posted by @mpenkov in https://github.com/RaRe-Technologies/smart_open/issues/559#issuecomment-730033024_

housekeeping

Looks like tests on Travis are expecting some new env variables that aren't being set correctly.

housekeeping

help wanted
housekeeping

https://hynek.me/articles/document-your-tests/

housekeeping

The logger will only print if the root logger is configured which is no guarantee. As far as that import path in `__init__.py` goes it would seem that it would...

housekeeping

Yeah, I agree that having random in the tests is a bit of a code smell, but it appears to be a core feature of those tests. I'm not sure...

housekeeping

> Please use `self.assertEqual`, here and everywhere: > > * It's consistent with the rest of the code > * It gives more informative messages via the test runner It...

housekeeping