Michael Penick

Results 74 comments of Michael Penick

Good call. I don't remember all the details on how token auth work in Stargate (I think it might be on a sliding window based on usage). I need a...

It looks like the `auth` service will return a cache control header with max age if there's not an error: https://github.com/stargate/stargate/blob/v1.0.63/auth-api/src/main/java/io/stargate/auth/api/resources/AuthResource.java#L193-L196

Here are my suggested changes. The cache logic could be simplified and it shouldn't cache if there's not a cache control header. Also, I think that the provider can be...

I like the reader pattern, that's pretty cool! I think it might be simplified, but maybe I'm missing something. I'm having trouble understanding the need for the intermediate type `StargateTableData`,...

> Definitely simpler, but I worry it keeps the caller in protocol buffer land longer than we'd like. Here are a few of the problems I'm trying to solve with...

Fix code to make it viewable: ```go practiceArray := []*proto.Value{ {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[0])}}, {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[1])}}, {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[2])}}, {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[3])}}, } var testCollection = &proto.Value_Collection{Collection: {Elements: practiceArray}} print(testCollection)...

This is the fix: `&proto.Value_Collection{Collection: {Elements: practiceArray}}` --> `&proto.Value_Collection{Collection: &proto.Collection{Elements: practiceArray}}` Full code (w/ fix): ```go practiceArray := []*proto.Value{ {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[0])}}, {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[1])}}, {Inner: &proto.Value_Int{Int: int64(data.M_suspensionPosition[2])}}, {Inner: &proto.Value_Int{Int:...

The protobuf type can be quite verbose and can be a bit difficult to use. This project is working toward making the Go gRPC API easier to use: https://github.com/datastax-ext/astra-go-sdk. It's...

That looks great! Huge improvement in usability and much more concise. > Happy to PR these, or wait and PR them once this is a bit more baked. If you're...

What's wrong with the original patch? https://github.com/datastax/cql-proxy/pull/127. It handles double quoting in the identifier.