sbt-idea
sbt-idea copied to clipboard
mpeltonen
Replace library dependencies with module dependencies
As discussed, this is my clone with optional "replace libraries by modules" functionality. The option to pass is "replace-libs" but of course feel free to change this.
This is my first pull request ever, so I am sure I am doing something wrong. In particular, I changed the README to reflect the changes I made, I hope this doesn't cause trouble. Likewise, there is very little extra code, but it could probably still be organized and placed better.
Finally I got some time to look into this, sorry...
Could you please make a new pull request (or change the commits in this one, if that's possible, I don't know) which would only include commits with changes for this feature, I.e. without any formatting and project definition changes irrelevant to this feature? It would be easier to review and merge.
Also make sure that scripted tests still pass after the changes (or even better, add some test for this feature).
Ah sure. Actually I tried to revert all formatting and irrelevant edits and thought this worked out. Not sure what happened, but I'll just try again. On Sep 6, 2012 5:57 PM, "Mikko Peltonen" [email protected] wrote:
Finally I got some time to look into this, sorry...
Could you please make a new pull request (or change the commits in this one, if that's possible, I don't know) which would only include commits with changes for this feature, I.e. without any formatting and project definition changes irrelevant to this feature? It would be easier to review and merge.
Also make sure that scripted tests still pass after the changes (or even better, add some test for this feature).
— Reply to this email directly or view it on GitHubhttps://github.com/mpeltonen/sbt-idea/pull/169#issuecomment-8339488.
Hmm, when I look at the diff (https://github.com/mpeltonen/sbt-idea/pull/169/files) it looks like the minimal, "no-formatting changes" version with only relevant changes. Or do do you mean the README file? In that case it would probably best to just take it out of the pull (if possible), as I intended the README to describe the changes made in this clone.
Actually I didn't know about the scripted tests, let me look into this.
Yeah, /files seems to be the end result of applying all the commits, but I'd prefer commit(s) with just relevant stuff.
@riedelcastro you can squash all the commits so, the result commit will contain only the end result of applying all the commits
I am sure I am missing something very obvious, but how do I run the scripted tests?
just type "scripted" in sbt console see more here http://eed3si9n.com/testing-sbt-plugins