Prompter icon indicating copy to clipboard operation
Prompter copied to clipboard

Do you have any plans to update this package to Swift 5?

Open willowell opened this issue 4 years ago • 1 comments

Hello! Do you have any plans to update this package to Swift 5?

I tried to include your package via .package(url: "https://github.com/mpclarkson/Prompter.git", from: "1.0.0"), in my Package.swift, but swift package update failed because

Updating https://github.com/mpclarkson/Prompter.git
error: because no versions of Prompter match the requirement 1.0.0..<2.0.0 and root depends on Prompter 1.0.0..<2.0.0, version solving failed.

I also noticed that the Swift Package Manager had a redesign in 2017, so perhaps the redesign broke your package?

https://swift.org/blog/swift-package-manager-manifest-api-redesign/

As a note, I have not tried to use your package through a podfile or with Xcode, so I do not know if the podfile needs an update too.

I'm relatively new to contributing on GitHub, so I could try taking a look myself and opening a PR, but I wanted to bring it to your attention first. :-)

willowell avatar Jul 30 '20 23:07 willowell

Hi there! I just finished updating your package to Swift 5 myself. I figured I would give it a go since I'm new to Swift. If you like, you can take a look at my branch and tell me what you think! 🙂 I would be grateful for the opportunity.

To build my branch:

OS: macOS 10.15.6
Swift version: Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53)
Xcode version: 11.6

1. Clone my branch and `cd` into it.
2. Run `swift build` and/or `swift test`.

In short, I trimmed your package down to just the structure that SPM expects for libraries, I consolidated the dependencies into Package.swift, and I updated the syntax in your package to Swift 5.

So, you will notice that my branch looks very plain - it does not have any Xcode-specific files or CocoaPods-specific files. I'm hoping that my branch is simple enough that hooking it up to Xcode and/or CocoaPods and CI/CD shouldn't be too hard.

Supposedly Xcode 11 natively understands SPM packages, but I do not have any experience with that yet.

willowell avatar Aug 03 '20 06:08 willowell