Clang V7.1.0 warning

[hkaiser]

We are seeing this warning while #including <variant.hpp> (V1.4.0) when using Clang 7.1.0:

/hpx/source/libs/datastructures/include/hpx/datastructures/detail/variant.hpp:2243:22: error: constructor accepting a forwarding reference can hide the copy and move constructors [bugprone-forwarding-reference-overload,-warnings-as-errors]
    inline constexpr variant(Arg &&arg) noexcept(
                     ^
/hpx/source/libs/datastructures/include/hpx/datastructures/detail/variant.hpp:2231:5: note: copy constructor declared here
    variant(const variant &) = default;
    ^
/hpx/source/libs/datastructures/include/hpx/datastructures/detail/variant.hpp:2232:5: note: move constructor declared here
    variant(variant &&) = default;

Anything we can do about this?

[mpark]

I think the only thing we could do probably is to #pragma disable the warning.

[hkaiser]

I think the only thing we could do probably is to #pragma disable the warning.

@mpark: yes, I agree.