mpalourdio
feat: dynamic filters update
As discussed in #194, this PR wants to propose a refactoring in order to allow dynamic filters inside the interceptor. This feature should be perfectly retrocompatible and it should not add any breaking changes.
@mpalourdio let me know what do you think
Pull Request Test Coverage Report for Build 8702418349
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 11 of 15 (73.33%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-4.4%) to 95.604%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/lib/services/pending-requests-interceptor.service.ts | 7 | 8 | 87.5% |
| src/lib/components/ng-http-loader.component.ts | 4 | 7 | 57.14% |
| <!-- | Total: | 11 | 15 |
| Totals | |
|---|---|
| Change from base Build 8505250527: | -4.4% |
| Covered Lines: | 77 |
| Relevant Lines: | 81 |
💛 - Coveralls
Thanks, looks cleaner as is, and the build is green. Now here the painful part :)
Theses features lack testing. I don't want to embed anything under 100% coverage, as it was before. This is a small lib, I just want to upgrade, fire, and forget. Life is too short to javascript all night long.
Also, I have a few concerns about the tests that have been modified, but as I understand, now that the @input have been moved to setters, we are not fully BC, particularly for apps that embed the component as @ViewChild.
I know a few of them, and it's a small change (but a change anyway). I guess this is the price to pay.
Also, README should reflect theses additions.
Anyway, good job.
Thank you! So, you need
- some more tests
- what kind of documentation you need in README?
Yes, the observable part needs testing now, so we have full coverage on every branch.
The README should reflect the fact that now, filters can be, or not, observables, with a small sample as example.