action-validator icon indicating copy to clipboard operation
action-validator copied to clipboard

Doesn't detect cyclic `needs`

Open bytesnz opened this issue 4 months ago • 1 comments

Want to help get this issue implemented? Donate to the action-validator code fund.


This doesn't seem to detect cyclic needs on the jobs.

name: cyclic-test
on:
  pull: {}
jobs:
  test:
    runs-on: ubuntu-latest
    needs:
      - test
    steps:
      - run: echo hello
  test1:
    runs-on: ubuntu-latest
    needs:
      - test2
    steps:
      - run: echo hello
  test2:
    runs-on: ubuntu-latest
    needs:
      - test1
    steps:
      - run: echo hello

bytesnz avatar Aug 10 '25 21:08 bytesnz

Indeed it doesn't. Thanks for the minimal test case, that'll help evaluating a PR to fix.

mpalmer avatar Aug 10 '25 23:08 mpalmer