action-validator icon indicating copy to clipboard operation
action-validator copied to clipboard

Action-Validator Github Action Example

Open mathew-fleisch opened this issue 3 years ago • 3 comments

Happy new year 😏

Hope all is well. I started using your action-validator directly in actions as a linting stage rather than a pre-commit hook. Thought I'd contribute back an example for this use case. Let me know if there is anything I can do on this PR (or the other one 😄).

mathew-fleisch avatar Mar 22 '22 15:03 mathew-fleisch

https://i.imgflip.com/6a48ie.jpg

mathew-fleisch avatar Mar 26 '22 16:03 mathew-fleisch

I like what you're thinking, and I'm leaning towards just going all-out and just making the action-validator runs part of the test workflow. That would allow the README to just say "as an example of how to use action-validator+asdf in a GitHub workflow, see :arrow_right: over there!", rather than copy-pasting the examples. Sound reasonable, and are you up for reworking your PR in that direction?

mpalmer avatar Mar 28 '22 04:03 mpalmer

☝️ how's that?

mathew-fleisch avatar Mar 28 '22 10:03 mathew-fleisch

I reworked this a little, fixed the conflicts, squashed it up, and committed as a46a8f3. Thanks for your contribution!

mpalmer avatar Jan 19 '23 23:01 mpalmer