action-validator icon indicating copy to clipboard operation
action-validator copied to clipboard

For the purposes of negative globs, treat them as positive globs.

Open krainboltgreene opened this issue 1 year ago • 6 comments

In Github you can define a "negative glob" aka, "not this path". To still validate this type of glob we simply check the opposite of that path.

krainboltgreene avatar Jan 05 '24 20:01 krainboltgreene

Hi Kurtis, good catch. I've never used a negative glob myself, so I guess that's why they don't work. :joy:

Clippy's got a bone to pick with you -- although I would have expected a regular build to fail, too, so I'll ponder what's going on there some other time. If you can add a couple of tests to the pile in test (maybe 003a_successful_negative_globs and 004a_failing_negative_globs?) that'll let me just click the "Merge" button when all the checks are green.

mpalmer avatar Jan 06 '24 01:01 mpalmer

Yeah I'm not sure what the problems here are, as all the documentation details this function as taking 2 arguments.

krainboltgreene avatar Jan 06 '24 13:01 krainboltgreene

oh, lol there's a replace function on Option: https://doc.rust-lang.org/std/option/enum.Option.html#method.replace

krainboltgreene avatar Jan 06 '24 13:01 krainboltgreene

Thanks for the updates, Kurtis. I'll get onto this by next week, I promise. :crossed_fingers:

mpalmer avatar Jan 08 '24 22:01 mpalmer

@mpalmer Any chance you could run the actions?

krainboltgreene avatar Jan 14 '24 07:01 krainboltgreene

Sorry, I thought once I'd approved them once they'd be run automatically thereafter. TIL...

mpalmer avatar Jan 14 '24 09:01 mpalmer

I created a second PR, #71, based on yours, and fixed up a few things. It's now merged, so we can consider this done, I reckon. Thanks for your work to make it happen!

mpalmer avatar Jan 30 '24 00:01 mpalmer